Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move messages to pinia store #10309

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 8, 2024

Description

Moves the messages from vuex store to pinia. You can simply use them via the new useMessages composable:

const { showMessage, showErrorMessage } = useMessages()

showMessage({ title: $gettext('User was created successfully') })

showErrorMessage({
    title: $gettext('Failed to create user'),
    errors
})

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jan 8, 2024
Copy link

update-docs bot commented Jan 8, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

46.11% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@JammingBen JammingBen requested review from dschmidt and kulmann January 8, 2024 17:48
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@JammingBen JammingBen merged commit 8242547 into master Jan 9, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the messages-to-pinia branch January 9, 2024 08:18
@JammingBen JammingBen mentioned this pull request Jan 19, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants